Merge pull request #218 from mdr-engineering/hotfix/ftd_na_UpdateJiraWindows

Backup Jira _before_ the maintenance window, and set backup retention

base/jira/rds_jira/main.tf

@@ -39,12 +39,11 @@ module "jira_db" {
 
   vpc_security_group_ids = [ aws_security_group.jira_rds_sg.id ]
 
-  # FTD: Should these be reversed? Backup _before_ maintenance?
-  maintenance_window = "Mon:00:00-Mon:03:00"
-  backup_window      = "03:00-06:00"
+  backup_window      = "00:00-03:00"
+  maintenance_window = "Mon:03:00-Mon:06:00"
 
-  # disable backups to create DB faster
-  backup_retention_period = 0
+  # Backup retention is from 0 to 35
+  backup_retention_period = var.environment == "test" ? 0 : 35
 
   tags = merge(var.standard_tags, var.tags)