Fixes Minor Issues During Apply All Everywhere

* app_s3_bucket, codebuild_splunk_docs,  and customer_portal_lambda had s3 policy with interpolated string.

To be tagged v5.3.3

base/codebuild_splunk_docs/cloudwatch.tf

@@ -81,7 +81,7 @@ POLICY
 resource "aws_iam_policy_attachment" "service_role_attachment" {
   name       = "splunk_docs_policy_attachment"
   policy_arn = aws_iam_policy.codebuild_policy.arn
-  roles      = ["${aws_iam_role.codebuild_role.id}"]
+  roles      = [aws_iam_role.codebuild_role.id]
 }
 
 resource "aws_cloudwatch_event_target" "trigger_build" {

base/customer_portal_lambda/s3.tf

@@ -43,7 +43,7 @@ data "aws_iam_policy_document" "s3_policy_document" {
     actions = ["s3:GetObject", "s3:GetObjectVersion"]
     effect  = "Allow"
     resources = [
-      "${aws_s3_bucket.bucket.arn}",
+      aws_s3_bucket.bucket.arn,
       "${aws_s3_bucket.bucket.arn}/*"
     ]
     principals {
@@ -117,4 +117,4 @@ resource "aws_kms_alias" "key_alias" {
     }
   }
 }
-*/
+*/

base/splunk_servers/app_s3_bucket/main.tf

@@ -78,7 +78,7 @@ data "aws_iam_policy_document" "policy" {
     sid    = "AccountAllow"
     effect = "Allow"
     resources = [
-      "${aws_s3_bucket.bucket.arn}",
+      aws_s3_bucket.bucket.arn,
       "${aws_s3_bucket.bucket.arn}/*"
     ]