resource "aws_s3_bucket" "crl" {
  bucket = "xdr-root-crl"

  tags   = merge(var.standard_tags, var.tags)

}

  # CRLs are small, but regenerated every expiration/2 days, (every 3.5 days by default), so there will be a good number of versions

resource "aws_s3_bucket_versioning" "s3_version_crl" {
  bucket   = aws_s3_bucket.crl.id

  versioning_configuration {
    status = "Enabled"
  }
}

  # TODO: Enable S3 logging... everywhere. We don't have a C2 bucket for this.
  #resource "aws_s3_bucket_logging" "log_bucket_audit_reports" {
  #  target_bucket = module.xdr_config_logging_bucket.s3_bucket_name
  #  target_prefix = "${var.aws_account_id}-${var.aws_region}-awsconfig/"
  #}

resource "aws_s3_bucket_lifecycle_configuration" "s3_lifecyle_crl" {
  bucket   = aws_s3_bucket.crl.id
  
  rule {
    id     = "CleanUp"
    status = "Enabled"
    
    abort_incomplete_multipart_upload {
      days_after_initiation = 7
    }

    noncurrent_version_expiration {
      noncurrent_days       = 365
    }
  }
}

resource "aws_s3_bucket_server_side_encryption_configuration" "s3_sse_crl" {
  bucket   = aws_s3_bucket.crl.id
  
  rule {
    apply_server_side_encryption_by_default {
      sse_algorithm = "AES256" # Default keys are fine. We don't really need encryption here.
      }
    }
}

data "aws_iam_policy_document" "acmpca_bucket_access" {
  statement {
    actions = [
      "s3:GetBucketAcl",
      "s3:GetBucketLocation",
      "s3:PutObject",
      "s3:PutObjectAcl",
    ]

    resources = [
      aws_s3_bucket.crl.arn,
      "${aws_s3_bucket.crl.arn}/*",
    ]

    principals {
      identifiers = ["acm-pca.amazonaws.com"]
      type        = "Service"
    }

    # TODO: Consider restricting this to the account, but may need to add Get permissions?
    # "Condition":{
    #       "StringEquals":{
    #          "aws:SourceAccount":"account",
    #          "aws:SourceArn":"arn:partition:acm-pca:region:account:certificate-authority/CA-ID"
    #       }
    #    }

  }
}

resource "aws_s3_bucket_policy" "crl" {
  bucket = aws_s3_bucket.crl.id
  policy = data.aws_iam_policy_document.acmpca_bucket_access.json
}

# We want the CRL publicly accessible for zero trust websites and such.
#resource "aws_s3_bucket_public_access_block" "crl_bucket_block_public_access" {
#  bucket                  = aws_s3_bucket.crl.id
#  block_public_acls       = false # Not supported for CRLs, see https://aws.amazon.com/premiumsupport/knowledge-center/s3-bucket-error-crl-acm-ca/
#  block_public_policy     = true
#  ignore_public_acls      = true
#  restrict_public_buckets = true
#  depends_on = [ aws_s3_bucket.crl ]
#}

//AWS Provider outdated arguments <4.4.0
/*resource "aws_s3_bucket" "crl" {
  bucket = "xdr-root-crl"

  # CRLs are small, but regenerated every expiration/2 days, (every 3.5 days by default), so there will be a good number of versions
  versioning {
    enabled = true
  }

  # TODO: Enable S3 logging... everywhere. We don't have a C2 bucket for this.
  #logging {
  #  target_bucket = module.xdr_config_logging_bucket.s3_bucket_name
  #  target_prefix = "${var.aws_account_id}-${var.aws_region}-awsconfig/"
  #}

  lifecycle_rule {
    id = "CleanUp"
    enabled = true
    abort_incomplete_multipart_upload_days = 7
    # Clean up old versions after a year
    noncurrent_version_expiration {
      days = 365
    }
  }

  server_side_encryption_configuration {
    rule {
      apply_server_side_encryption_by_default {
        sse_algorithm = "AES256" # Default keys are fine. We don't really need encryption here.
      }
    }
  }

  tags = merge(var.standard_tags, var.tags)
}
*/